ISPN-13165 AsyncOfflineTest.testReset random failures (take 2) #9647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danberindei
reviewed
Nov 17, 2021
core/src/main/java/org/infinispan/xsite/irac/DefaultIracManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/infinispan/xsite/irac/DefaultIracManager.java
Outdated
Show resolved
Hide resolved
pruivo
force-pushed
the
t_13165_take2
branch
from
19ef7fa
to
18c84ab
Compare
|
updated |
danberindei
reviewed
Nov 18, 2021
pruivo
force-pushed
the
t_13165_take2
branch
from
18c84ab
to
375080b
Compare
|
updated
|
danberindei
reviewed
Nov 19, 2021
core/src/main/java/org/infinispan/xsite/irac/DefaultIracManager.java
Outdated
Show resolved
Hide resolved
Problems: * State.accept() and onSendingCompleted() were running concurrently. * onSendingCompleted() triggers an IRAC round but the State.stateStatus was not updated. * The new round would not retry to send the key again making the test fail.
pruivo
force-pushed
the
t_13165_take2
branch
from
375080b
to
aa798e5
Compare
|
updated! |
|
Merged, thanks Pedro! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems:
was not updated.
https://issues.redhat.com/browse/ISPN-13165
馃