Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-1881 Refactor CommandAwareRpcDispatcher to treat calls to single re... #974

Closed
wants to merge 1 commit into from

Conversation

maniksurtani
Copy link
Member

...cipients in a more optimised manner

  • Also make SuccessfulResponse a singleton for null payloads

See https://issues.jboss.org/browse/ISPN-1881

Also pls merge t_1881_5 for branch 5.1.x

… recipients in a more optimised manner

* Also make SuccessfulResponse a singleton for null payloads
@galderz galderz closed this Feb 27, 2012
@@ -410,7 +462,7 @@ public synchronized void futureDone(Future<Object> objectFuture) {
if (sc.processed) {
// This can happen - it is a race condition in JGroups' NotifyingFuture.setListener() where a listener
// could be notified twice.
if (trace) log.tracef("Not processing callback; already processed callback for sender %s", sc.address);
log.tracef("Not processing callback; already processed callback for sender %s", sc.address);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you shouldn't remove if (trace) as checking the static constant will always be better than actually invoking the tracef method

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops - I'm not sure why I removed that. :/

On 27 February 2012 11:11, Sanne Grinovero <
reply@reply.github.com

wrote:

@@ -410,7 +462,7 @@ public synchronized void futureDone(Future
objectFuture) {
if (sc.processed) {
// This can happen - it is a race condition in JGroups'
NotifyingFuture.setListener() where a listener
// could be notified twice.

  •        if (trace) log.tracef("Not processing callback; already
    
    processed callback for sender %s", sc.address);
  •        log.tracef("Not processing callback; already processed
    
    callback for sender %s", sc.address);

you shouldn't remove if (trace) as checking the static constant will
always be better than actually invoking the tracef method


Reply to this email directly or view it on GitHub:
https://github.com/infinispan/infinispan/pull/974/files#r490659

Manik

Sent from my iPad 4 beta 3 with a telekinetic keyboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants