Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-13585 Disable PDF generation #9747

Merged

Conversation

tristantarrant
Copy link
Member

@pruivo
Copy link
Member

pruivo commented Dec 15, 2021

@oraNod can we remove the pdf generation?

@oraNod
Copy link
Contributor

oraNod commented Dec 15, 2021

I encountered a build failure with the distribution. But if I commented this line the build was fine: 3c53e8e#diff-50bda33cd95bf7733f9c86e14888dcac8d987c8b663c9816f021b92a188b75d4R380

@tristantarrant I think we need to drop <descriptor>src/main/assemblies/pdf.xml</descriptor>

@oraNod
Copy link
Contributor

oraNod commented Dec 15, 2021

@oraNod can we remove the pdf generation?

@pruivo Yes, I think it's fine. We don't link to the PDF on the site anymore. That transform was used for the PDF links on some of the old index.html pages like 9.4.x: https://infinispan.org/docs/9.4.x/index.html

For 14 and later we don't link to PDFs from the site so it's kind of a pointless run. I will double check everything now though to be sure.

@tristantarrant tristantarrant force-pushed the ISPN-13585/disable_pdf_generation branch from 3c53e8e to 4d4083f Compare December 15, 2021 11:43
@pruivo
Copy link
Member

pruivo commented Dec 15, 2021

great! @tristantarrant you can remove the pdf generation 👍

@oraNod oraNod self-requested a review December 15, 2021 11:59
Copy link
Contributor

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oraNod oraNod merged commit c8d2eb1 into infinispan:main Dec 15, 2021
@oraNod
Copy link
Contributor

oraNod commented Dec 15, 2021

Thanks @tristantarrant !!

tristantarrant added a commit that referenced this pull request Jun 7, 2022
@tristantarrant tristantarrant deleted the ISPN-13585/disable_pdf_generation branch July 5, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants