Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-13446 IRAC: configure the tombstone cleanup task #9853

Merged
merged 1 commit into from Feb 16, 2022

Conversation

pruivo
Copy link
Member

@pruivo pruivo commented Jan 31, 2022

  • Dynamic task based on a target map size: if the current number of stored
    tombstones are higher, decrease the schedule interval to make the
    cleanup task more frequent (and vice-versa).

Copy link
Contributor

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed another doc edit @pruivo and LGTM. Thanks!

Copy link
Member

@danberindei danberindei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say I love the algorithm for adjusting the delay...
I put a comment in DefaultIracTombstoneManager with what I think would be a better approach.

@pruivo
Copy link
Member Author

pruivo commented Feb 4, 2022

updated with the following changes

  • Changed attribute name from "interval" to "delay".
  • Added test to the scheduler suggested by Dan.
  • Added metric to report the current delay value.
  • DynamicTask removed.

@pruivo pruivo force-pushed the t_13446 branch 2 times, most recently from 8c43cec to 4ef6e4c Compare February 8, 2022 10:49
@pruivo pruivo force-pushed the t_13446 branch 3 times, most recently from b88da9d to 66bc463 Compare February 10, 2022 09:21
Dynamic task based on a target map size: if the current number of stored
tombstones are higher, decrease the schedule interval to make the
cleanup task more frequent (and vice-versa).
@danberindei
Copy link
Member

Merged, thanks Pedro!

@pruivo pruivo deleted the t_13446 branch February 17, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants