New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISPN-13446 IRAC: configure the tombstone cleanup task #9853
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed another doc edit @pruivo and LGTM. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't say I love the algorithm for adjusting the delay...
I put a comment in DefaultIracTombstoneManager with what I think would be a better approach.
commons/all/src/main/java/org/infinispan/commons/logging/Log.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/infinispan/configuration/cache/SitesConfigurationBuilder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/infinispan/configuration/cache/SitesConfigurationBuilder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/infinispan/container/versioning/irac/DefaultIracTombstoneManager.java
Outdated
Show resolved
Hide resolved
updated with the following changes
|
core/src/main/java/org/infinispan/configuration/parsing/Attribute.java
Outdated
Show resolved
Hide resolved
8c43cec
to
4ef6e4c
Compare
core/src/main/java/org/infinispan/container/versioning/irac/DefaultIracTombstoneManager.java
Outdated
Show resolved
Hide resolved
b88da9d
to
66bc463
Compare
core/src/test/java/org/infinispan/xsite/irac/IracTombstoneUnitTest.java
Outdated
Show resolved
Hide resolved
Dynamic task based on a target map size: if the current number of stored tombstones are higher, decrease the schedule interval to make the cleanup task more frequent (and vice-versa).
Merged, thanks Pedro! |
tombstones are higher, decrease the schedule interval to make the
cleanup task more frequent (and vice-versa).