ISPN-1899 #990
Closed
ISPN-1899 #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm, this should be in 5.1.x too. |
|
I'm cherry picking it... |
|
thanks galder. I agree, just that when I made it @maniksurtani had decided he would personally pick stuff from master to better control changes. We're not in paranoid mode anymore? |
|
hmmm, did he say that? i think this is a very valid fix for 5.1.x - btw, its done |
|
I do agree, no problem at all. Just explaining why I've not been sending pull requests for 5.1 explicitly but rather leaving it to reviewer judgement. |
|
Sure, that's fine :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISPN-1899 and some minor improvements.