Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-13737 Allow configuring file-less keystores #9926

Merged
merged 1 commit into from Mar 3, 2022
Merged

ISPN-13737 Allow configuring file-less keystores #9926

merged 1 commit into from Mar 3, 2022

Conversation

tristantarrant
Copy link
Member

@ryanemerson
Copy link
Contributor

There's a related test failure:

[org.infinispan.server.configuration.ServerConfigurationSerializerTest.testConfigurationSerialization[14.0.xml > [application/xml]]](https://ci.infinispan.org/job/Infinispan/job/PR-9926/1/testReport/junit/org.infinispan.server.configuration/ServerConfigurationSerializerTest/testConfigurationSerialization_14_0_xml____application_xml__/)

ryanemerson
ryanemerson reviewed Mar 3, 2022
View reviewed changes
documentation/src/main/asciidoc/topics/proc_configuring_server_fips.adoc Outdated Show resolved Hide resolved
documentation/src/main/asciidoc/topics/proc_configuring_server_fips.adoc Outdated Show resolved Hide resolved
server/runtime/src/main/resources/schema/infinispan-server-14.0.xsd Outdated Show resolved Hide resolved
server/runtime/src/main/java/org/infinispan/server/logging/Log.java Outdated Show resolved Hide resolved
server/runtime/src/main/resources/schema/infinispan-server-14.0.xsd Outdated
<xs:annotation>
<xs:documentation>
Specifies the location of the keystore on the host file system. You can set a relative or absolute value.
If you set a relative value, configure a value for the 'relative-to' attribute.
The type of the keystore will be auto-detected among JKS, JCEKS, PKCS12 or PEM.
BKS, BCFKS and UBER are also supported if the `bouncycastle` libary is present.
The path may be omitted when using global stores providers, such as 'SunPKCS11-nss-fips'.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"store providers"

server/runtime/src/main/java/org/infinispan/server/security/KeyStoreUtils.java Outdated Show resolved Hide resolved
server/runtime/src/main/java/org/infinispan/server/security/KeyStoreUtils.java Show resolved Hide resolved
@tristantarrant
Copy link
Member Author

I've added testing instructions to the Jira

@tristantarrant
Copy link
Member Author

The failure doesn't happen locally. Let's see what CI says now.
I've also added testing instructions to the Jira

@ryanemerson ryanemerson merged commit 332af4d into infinispan:main Mar 3, 2022
@ryanemerson
Copy link
Contributor

Thanks @tristantarrant

@tristantarrant tristantarrant deleted the ISPN-13737/fips branch July 5, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanemerson ryanemerson ryanemerson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tristantarrant @ryanemerson