Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added registerProtostreamType function #82

Merged
merged 2 commits into from Jul 27, 2022

Conversation

NeerajGartia21
Copy link
Collaborator

@NeerajGartia21 NeerajGartia21 commented Jul 26, 2022

This PR is for the issue #72

This PR is the first part of adding protobuf encoded cache feature in the js client.

Protostream is a Protobuf based serialization library, is used by Infinispan to serialize cache entries preserving their type. Client should support protobuf encode/decode for mediatype application/x-protostream.

The proposed design for adding this feature is provided below.

- procedure for setting up the client:

  1. Register the protobuf schema type using registerProtostreamType function by providing the package full name and an id for the schema.
  2. Encode the message object using the protobuf schema.

In this PR the registerProtostream type function is implemented. Also new mediaType application/x-protostream is added.

lib/protocols.js Outdated Show resolved Hide resolved
@rigazilla
Copy link
Contributor

@NeerajGartia21 this looks good to me. If all the code for the Setup Time (as describe here) is in I would merge this and go ahead with the Working Time code in a new PR, so to keep PRs small.
Wdyt?

@rigazilla rigazilla added the GSoC label Jul 27, 2022
@NeerajGartia21
Copy link
Collaborator Author

I think after committing requested changes all code for setup time are in.

@rigazilla rigazilla merged commit 74f8818 into infinispan:main Jul 27, 2022
@rigazilla
Copy link
Contributor

merged, thanks @NeerajGartia21 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants