Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPROTO-230 Fix MarshallerByteCodeGenerator on JDK 17 #152

Merged
merged 1 commit into from Apr 7, 2022

Conversation

tristantarrant
Copy link
Member

@@ -1,6 +1,7 @@
package org.infinispan.protostream.annotations.impl.types;

import java.lang.annotation.Annotation;
import java.lang.invoke.MethodHandles;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes can be reverted IMO

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, fixed

@pruivo
Copy link
Member

pruivo commented Apr 7, 2022

got the following error

[ERROR] Failures: 
[ERROR]   AnnotationProcessorCompilationTest.testAdapter:133 Expected 0 warnings, but found the following 1 warnings:
Integer(int) in java.lang.Integer has been deprecated and marked for removal
Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d)
Maven home: /home/pedro/.opt/java/maven
Java version: 17.0.1, vendor: Eclipse Adoptium, runtime: /home/pedro/.opt/java/jdk-17.0.1+12
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.16.14-1-manjaro", arch: "amd64", family: "unix"

It looks like the generator needs to be updated. Investigating...

/SOURCE_OUTPUT/test_marshall_externals/AddressAdapter$___Marshaller_ce46b223cf7571fb6dc96c1c4cdd0435322f78d395b675f266ac6e23af7d306b.java:54: warning: [removal] Integer(int) in java.lang.Integer has been deprecated and marked for removal
               __v$3 = new java.lang.Integer($in.readInt32());
                       ^

@tristantarrant
Copy link
Member Author

Now I see it too. Let me explore

@pruivo
Copy link
Member

pruivo commented Apr 7, 2022

org.infinispan.protostream.annotations.impl.AbstractMarshallerCodeGenerator line 875

@tristantarrant
Copy link
Member Author

I have fixed the deprecations

@pruivo pruivo merged commit d93ea29 into infinispan:main Apr 7, 2022
@pruivo
Copy link
Member

pruivo commented Apr 7, 2022

merged! thanks @tristantarrant !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants