IPROTO-307 @Proto annotation #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristantarrant
force-pushed
the
IPROTO-307/protosimple
branch
from
b4cb3ad
to
9ebdfcf
Compare
tristantarrant
changed the title
ryanemerson
reviewed
Mar 11, 2024
| /** | ||
| * Defines a Protocol Buffers message without having to annotate all fields with {@link ProtoField}. | ||
| * Use this annotation to quickly generate messages from records or classes with public fields. | ||
| * Fields must be public and they will be assigned incremental numbers based on the declaration order. |
There was a problem hiding this comment.
We should detail here that it's possible to overwrite fields with subsequent @protofield definitions.
| generatedSchema.registerSchema(ctx); | ||
| generatedSchema.registerMarshallers(ctx); | ||
|
|
||
| assertTrue(generatedSchema.getProtoFile().contains("message BareMessage")); |
There was a problem hiding this comment.
Should we also assert the generated fields contain the correct types?
ryanemerson
reviewed
Mar 11, 2024
| protobufType = Type.BYTES; | ||
| } | ||
| if (!javaType.isArray() && !javaType.isPrimitive() && javaType.isAbstract() && !javaType.isEnum()) { | ||
| throw new ProtoSchemaBuilderException("The type " + javaType.getCanonicalName() + " of field '" + fieldName + "' of " + clazz.getCanonicalName() + " should not be abstract, while processing " + this.protoSchemaGenerator.generator); |
There was a problem hiding this comment.
We throw the same exception in two places. We should either split the duplicated code into a method, or at least create the exception via the Log.
There was a problem hiding this comment.
I've promoted a few logs to Log, including this one.
|
This is making my day |
* IPROTO-306 Record support
tristantarrant
force-pushed
the
IPROTO-307/protosimple
branch
from
9ebdfcf
to
9395b90
Compare
ryanemerson
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/IPROTO-307
https://issues.redhat.com/browse/IPROTO-306
Adds a
@Protoannotation for simple handling of protobuf entities. Also adds support for Javarecords