feat: sonarqube tasks added to pipeline #8
Conversation
The pipeline has been updated to include the sonarqube tasks Dev dependency nyc has been included Script test:report has been added Dockerignore and gitignore updated Renaming of the docker build task
| @@ -2,6 +2,6 @@ version: '3' | |||
|
|
|||
| services: | |||
| service: | |||
| image: ilwebshops.azurecr.io/infinitaslearning/<%= name %>:latest | |||
| image: ilwebshops.azurecr.io/infinitaslearning/<%= name %>:latest # Change to the proper container registry | |||
There was a problem hiding this comment.
maybe should the registry being an env var or a new var requested when you launch yeoman?
There was a problem hiding this comment.
You're right it should be. However, I think it is not part of the scope of this PR
There was a problem hiding this comment.
I left the comment there because it was hardcoded and not clear to see that it must be changed. We could do a new var request while making the template on a new PR, sounds good to me
| displayName: 'sonarqube: publish analysis' | ||
| inputs: | ||
| pollingTimeoutSec: '300' | ||
|
|
||
| - task: Docker@2 | ||
| displayName: push |
There was a problem hiding this comment.
@w3dani @dustytrinkets I think we also have to validate if it is in master or not as we will get errors in the PR.
There was a problem hiding this comment.
Just add pr: none to azure-pipeline.yaml, that will prevent to run build on PR merge requests. No need to filter by branch.
| @@ -2,6 +2,6 @@ version: '3' | |||
|
|
|||
| services: | |||
| service: | |||
| image: ilwebshops.azurecr.io/infinitaslearning/<%= name %>:latest | |||
| image: ilwebshops.azurecr.io/infinitaslearning/<%= name %>:latest # Change to the proper container registry | |||
Type:
What's the focus of this PR:
The pipeline has been updated to include the sonarqube tasks
Dev dependency nyc has been included
Script test:report has been added
Dockerignore and gitignore updated
Renaming of the docker build task
How to review this PR: