Skip to content
This repository has been archived by the owner on Mar 9, 2021. It is now read-only.

Integration tests creating githooks error #51

Closed
robinheinze opened this issue May 22, 2017 · 4 comments · Fixed by #53
Closed

Integration tests creating githooks error #51

robinheinze opened this issue May 22, 2017 · 4 comments · Fixed by #53

Comments

@robinheinze
Copy link
Member

After running integration tests, the following error spits out when running git commands:

line 18: cd: IntegrationTest/IntegrationTest: No such file or directory

There's an error for each hook, so on commit, it spits out:

.git/hooks/pre-commit: line 18: cd: IntegrationTest/IntegrationTest: No such file or directory
.git/hooks/prepare-commit-msg: line 18: cd: IntegrationTest/IntegrationTest: No such file or directory
.git/hooks/commit-msg: line 18: cd: IntegrationTest/IntegrationTest: No such file or directory
.git/hooks/post-commit: line 18: cd: IntegrationTest/IntegrationTest: No such file or directory
.git/hooks/post-rewrite: line 18: cd: IntegrationTest/IntegrationTest: No such file or directory

It doesn't seem to block the git action, (i.e. Still able to commit and push successfully).

@jamonholmgren
Copy link
Member

@robinheinze I've noticed this for a while and am constantly aggravated by it. I haven't had time to look into it. I just run rm -rf ./.git/hooks each time ;)

@jamonholmgren
Copy link
Member

I don't think we should integrate husky or git hooks into our boilerplate at all, btw.

@jamonholmgren
Copy link
Member

#53 fixes this issue by removing husky (temporarily, but I think it should be permanently, and make husky an optional plugin)

@skellock
Copy link
Contributor

It's an issue because we're running the integration tests within an existing repo. Repo in a repo isn't a good thing.

I'm happy to see husky go for the boilerplate.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants