This repository has been archived by the owner on Mar 9, 2021. It is now read-only.
Replaced React.PropTypes with prop-types package #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very cool. I think we might be moving towards not using proptypes in the future. Thoughts? Here at IR we'll probably move towards Typescript as an Ignite Plugin... |
GantMan
approved these changes
Jun 27, 2017
|
@GantMan From a technical perspective i think thats a great idea. Only when first using this boilerplate you have to learn alot of new things at once, so adding Typescript might be a bit much. If it could be an one or the other thing that would be awesome. But that means taking the proptypes to a plugin as well. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html#migrating-from-react.proptypes