upgraded default react-native version #228

lvlrSajjad · 2018-11-21T18:59:57Z

upgraded default react-native version to 0.57.7

updated react-navigation to 3.0.0

also updated ignite-dev-screens,redux,redux-persist and some other libs to the last version

after changes i got it running in android and it was ok

removed allowFontScaling from boilerplate/App/Config/index.js cause it causes error in new react-native version

morgandonze · 2018-11-21T21:22:55Z

Thanks for the PR @lvlrSajjad.

Semaphoreci has some complaints:

standard: Use JavaScript Standard Style (https://standardjs.com)
standard: Run `standard --fix` to automatically fix some problems.
  /home/runner/ignite-ir-boilerplate-andross/boilerplate.js:181:30: Strings must use singlequote.
  /home/runner/ignite-ir-boilerplate-andross/boilerplate.js:181:61: Strings must use singlequote.
  /home/runner/ignite-ir-boilerplate-andross/boilerplate.js:183:5: Block must not be padded by blank lines.

Could you fix those please?

lvlrSajjad · 2018-11-21T21:29:10Z

Thanks for the PR @lvlrSajjad.

Semaphoreci has some complaints:

standard: Use JavaScript Standard Style (https://standardjs.com)
standard: Run `standard --fix` to automatically fix some problems.
  /home/runner/ignite-ir-boilerplate-andross/boilerplate.js:181:30: Strings must use singlequote.
  /home/runner/ignite-ir-boilerplate-andross/boilerplate.js:181:61: Strings must use singlequote.
  /home/runner/ignite-ir-boilerplate-andross/boilerplate.js:183:5: Block must not be padded by blank lines.

Could you fix those please?

yes taken care of but it says

The `ignite generate` command must be run in an ignite-compatible directory

while it generates correctly
it seems even in the main version of ignite-andross-boilerplate we have same error i've tested a clone and got same errors

just needed '--npm' flag

lvlrSajjad · 2018-11-22T00:43:21Z

in semaphore log it seems we getting errors like these

Yarn supports the following semver range: "^4.8.0 || ^5.7.0 || ^6.2.2 || >=8.0.0"\nerror react-native@0.57.5: The engine "node" is incompatible with this module. Expected version ">=8.3".\nerror Found incompatible module\n{ Error: Command failed: yarn add react-native@0.57.5

Command `yarn add react-native@0.57.5 --exact` failed

i think the semaphor's yarn/npm version is in incompatible with react-native@0.57.5.

in my system i can run this test at least the first one successfully passes .

by its installation guid https://reactnavigation.org/docs/en/getting-started.html we need to add something to MyActivity class in android , not needed in ios. so i patched file in boilerplate.js

lvlrSajjad · 2018-11-26T00:02:44Z

Just ignite-dev-screens may not work with this version of react-navigation (3.0.0) so if you merge this , i will upgrade the plugin too
also i have semaphor's yarn version errors yet
more info about errors
Here
and
Here

morgandonze · 2018-11-28T03:22:51Z

@lvlrSajjad we're removing Semaphore from this project and adding Circle CI instead. We can ignore the Semaphore failure and see whether it passes on Circle once it's ready.

lvlrSajjad · 2018-11-28T16:46:08Z

@lvlrSajjad we're removing Semaphore from this project and adding Circle CI instead. We can ignore the Semaphore failure and see whether it passes on Circle once it's ready.

i just accidently closed the pull
@mlaco i must fetch your circle config to being testable with circle ?

morgandonze · 2018-11-29T03:46:18Z

@lvlrSajjad yes, you'll need the circle config, but it looks like you got it already.
We need to trigger Circle to test your branch. Please make an empty commit using
git commit --allow-empty -m "fix(ci): Testing CI release" to do so.

lvlrSajjad · 2018-11-30T19:06:57Z

well it seems it can't find lint command in package.json of installed project . maybe it can't run ignite add standard

morgandonze · 2018-11-30T19:14:21Z

well it seems it can't find lint command in package.json of installed project . maybe it can't run ignite add standard

Yep. I'm currently trying to figure out why. It's able to do it on the master branch, so I'm kind of stumped.

lvlrSajjad · 2018-11-30T19:28:57Z

well it seems it can't find lint command in package.json of installed project . maybe it can't run ignite add standard

Yep. I'm currently trying to figure out why. It's able to do it on the master branch, so I'm kind of stumped.

i found problem it's something wrong with my react-navigation linking , i will cover it :-D @mlaco

morgandonze · 2018-11-30T19:36:00Z

Congrats, it worked!

morgandonze · 2018-11-30T19:36:44Z

Let me just look over the code again before I merge (I want to get a second review too)

lvlrSajjad · 2018-11-30T19:37:46Z

@mlaco Test passed but i need to find the problem with patch in file :-D cause i need to do that modifications on mainactivity.java as this link says
https://reactnavigation.org/docs/en/getting-started.html

morgandonze

I asked our team for a second review, too

markrickert · 2018-11-30T19:54:11Z

boilerplate.js

+      import com.facebook.react.ReactRootView;
+      import com.swmansion.gesturehandler.react.RNGestureHandlerEnabledRootView;`
+    })
+    //


Should this commented out section be left in without an explanation of why it's commented out in favor of the code block above it?

for now i'm just commenting / uncommenting stuff till i findout what is wrong i'll say when i'm done

markrickert · 2018-11-30T19:54:42Z

boilerplate.js

@@ -197,7 +219,7 @@ async function install (context) {
    }

    if (answers['redux-persist'] === 'Yes') {
-      await system.spawn(`ignite add redux-persist@"~>1.0.1" ${debugFlag}`, {
+      await system.spawn(`ignite add redux-persist@"~>5.10.0" ${debugFlag}`, {


HOLY CRAP that's a massive version upgrade!

lvlrSajjad · 2018-11-30T20:05:11Z

Guys I'm done
@mlaco thank's for being patient and helping me to figure this out
@markrickert thank's for reviews

morgandonze · 2018-11-30T22:59:10Z

@lvlrSajjad yes, thank you! I appreciate your hard work and dedication.

# [2.4.0](v2.3.1...v2.4.0) (2018-12-01) ### Bug Fixes * **ci:** Testing CI release ([ef979cc](ef979cc)) * **ci:** Testing CI release ([83e6a3d](83e6a3d)) * **ci:** Testing CI release ([4ff0748](4ff0748)) ### Features * **react-native:** upgraded default react-native version ([#228](#228)) ([575d24c](575d24c))

infinitered-circleci · 2018-12-01T22:52:42Z

🎉 This PR is included in version 2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

lvlrSajjad added 3 commits November 21, 2018 22:26

upgraded default react-native version

ebce352

fixed jest error

1460488

updated react-navigation

88fb4de

just linted boilerplate.js

4b7e688

lvlrSajjad added 5 commits November 22, 2018 03:34

fixed semaphore errors

9839c8b

just needed '--npm' flag

semaphore lint error again

4a27f09

removed some awaits

9f49dc7

semaphore debug

13fbc9c

semaphore debug non npm

d92a4a3

lvlrSajjad added 2 commits November 25, 2018 06:09

bumped react-navigation to 3.0.0

be8ba57

added second react-navigation installation step

18c24c9

by its installation guid https://reactnavigation.org/docs/en/getting-started.html we need to add something to MyActivity class in android , not needed in ios. so i patched file in boilerplate.js

lvlrSajjad mentioned this pull request Nov 27, 2018

Bumped RN version to 0.57.7 infinitered/ignite-bowser#125

Merged

lvlrSajjad closed this Nov 28, 2018

lvlrSajjad reopened this Nov 28, 2018

lvlrSajjad added 6 commits November 28, 2018 20:25

copied the circle ci config changes

d04c2ff

Delete config.yml

18f16e9

Create config.yml

9b92ac8

fixed confilcts

c17e145

bumped up to 0.57.7

a69782a

Update config.yml

cb0b628

lvlrSajjad added 3 commits November 29, 2018 13:11

fix(ci): Testing CI release

28d1f0e

fix(ci): Testing CI release

c64825a

Merge branch 'master' into master

3e24e74

lvlrSajjad added 2 commits November 30, 2018 22:15

Update generators-integration.test.js

4c86c00

copied tests from original repo

6b41186

Update generators-integration.test.js

c3a6631

debug flag

bb8dbae

commented ignite.patchfiles in boilerplate.js

13041d1

morgandonze self-requested a review November 30, 2018 19:44

morgandonze approved these changes Nov 30, 2018

View reviewed changes

lvlrSajjad added 2 commits November 30, 2018 23:15

debugging pathInFile Situation

20f8744

debugging pathInFileSituation

614943a

markrickert reviewed Nov 30, 2018

View reviewed changes

removed console.logs

3996277

lvlrSajjad added 3 commits November 30, 2018 23:52

removed another console.log

a178456

changed version in readme too

e68c76c

bumped up reactotron

8cd68ec

morgandonze merged commit 575d24c into infinitered:master Nov 30, 2018

infinitered-circleci added the released label Dec 1, 2018

This was referenced Dec 4, 2018

glog-0.3.4 error : 'config.h' file not found #224

Closed

Update React Native version to 57 #227

Closed

react-native run-ios not working with latest xcode? #225

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upgraded default react-native version #228

upgraded default react-native version #228

lvlrSajjad commented Nov 21, 2018 •

edited

morgandonze commented Nov 21, 2018

lvlrSajjad commented Nov 21, 2018 •

edited

lvlrSajjad commented Nov 22, 2018 •

edited

lvlrSajjad commented Nov 26, 2018 •

edited

morgandonze commented Nov 28, 2018

lvlrSajjad commented Nov 28, 2018

morgandonze commented Nov 29, 2018

lvlrSajjad commented Nov 30, 2018

morgandonze commented Nov 30, 2018

lvlrSajjad commented Nov 30, 2018 •

edited

morgandonze commented Nov 30, 2018

morgandonze commented Nov 30, 2018 •

edited

lvlrSajjad commented Nov 30, 2018

morgandonze left a comment

markrickert Nov 30, 2018

lvlrSajjad Nov 30, 2018

markrickert Nov 30, 2018

lvlrSajjad commented Nov 30, 2018

morgandonze commented Nov 30, 2018

infinitered-circleci commented Dec 1, 2018

upgraded default react-native version #228

upgraded default react-native version #228

Conversation

lvlrSajjad commented Nov 21, 2018 • edited

morgandonze commented Nov 21, 2018

lvlrSajjad commented Nov 21, 2018 • edited

lvlrSajjad commented Nov 22, 2018 • edited

lvlrSajjad commented Nov 26, 2018 • edited

morgandonze commented Nov 28, 2018

lvlrSajjad commented Nov 28, 2018

morgandonze commented Nov 29, 2018

lvlrSajjad commented Nov 30, 2018

morgandonze commented Nov 30, 2018

lvlrSajjad commented Nov 30, 2018 • edited

morgandonze commented Nov 30, 2018

morgandonze commented Nov 30, 2018 • edited

lvlrSajjad commented Nov 30, 2018

morgandonze left a comment

Choose a reason for hiding this comment

markrickert Nov 30, 2018

Choose a reason for hiding this comment

lvlrSajjad Nov 30, 2018

Choose a reason for hiding this comment

markrickert Nov 30, 2018

Choose a reason for hiding this comment

lvlrSajjad commented Nov 30, 2018

morgandonze commented Nov 30, 2018

infinitered-circleci commented Dec 1, 2018

lvlrSajjad commented Nov 21, 2018 •

edited

lvlrSajjad commented Nov 21, 2018 •

edited

lvlrSajjad commented Nov 22, 2018 •

edited

lvlrSajjad commented Nov 26, 2018 •

edited

lvlrSajjad commented Nov 30, 2018 •

edited

morgandonze commented Nov 30, 2018 •

edited