fix(hooks): Fix #274 - Add eslint-plugin-react-hooks (#369 by @noname…

…olsson)

[skip ci]

boilerplate/app/components/switch/switch.tsx

@@ -74,12 +74,9 @@ export function Switch(props: SwitchProps) {
       startAnimation(props.value)
       setPreviousValue(props.value)
     }
-  }, [props.value])
+  }, [previousValue, props.value, startAnimation])
 
-  const handlePress = React.useMemo(() => () => props.onToggle && props.onToggle(!props.value), [
-    props.onToggle,
-    props.value,
-  ])
+  const handlePress = React.useMemo(() => () => props.onToggle && props.onToggle(!props.value), [props])
 
   if (!timer) {
     return null

boilerplate/app/navigation/navigation-utilities.tsx

@@ -1,4 +1,4 @@
-import React, { useState, useEffect, useRef } from "react"
+import React, { useCallback, useState, useEffect, useRef } from "react"
 import { BackHandler } from "react-native"
 import { PartialState, NavigationState, NavigationContainerRef } from "@react-navigation/native"
 
@@ -110,18 +110,18 @@ export function useNavigationPersistence(storage: any, persistenceKey: string) {
     storage.save(persistenceKey, state)
   }
 
-  const restoreState = async () => {
+  const restoreState = useCallback(async () => {
     try {
       const state = await storage.load(persistenceKey)
       if (state) setInitialNavigationState(state)
     } finally {
       setIsRestoringNavigationState(false)
     }
-  }
+  }, [persistenceKey, storage])
 
   useEffect(() => {
     if (isRestoringNavigationState) restoreState()
-  }, [isRestoringNavigationState])
+  }, [isRestoringNavigationState, restoreState])
 
   return { onNavigationStateChange, restoreState, initialNavigationState }
 }

boilerplate/app/services/reactotron/reactotron.ts.ejs

@@ -126,6 +126,7 @@ export class Reactotron {
       if (this.config.useAsyncStorage) {
         Tron.setAsyncStorageHandler(AsyncStorage)
       }
+      // eslint-disable-next-line react-hooks/rules-of-hooks
       Tron.useReactNative({
         asyncStorage: this.config.useAsyncStorage ? undefined : false,
       })

boilerplate/package.json.ejs

@@ -84,6 +84,7 @@
     "eslint-plugin-promise": "^4.0.1",
     "eslint-plugin-react": "^7.12.4",
     "eslint-plugin-react-native": "^3.6.0",
+    "eslint-plugin-react-hooks": "^4.1.0",
     "eslint-plugin-standard": "^4.0.0",
     "jest": "25.5.4",
 <% if (props.useExpo) { -%>
@@ -163,6 +164,7 @@
       "plugin:@typescript-eslint/recommended",
       "plugin:react/recommended",
       "plugin:react-native/all",
+      "plugin:react-hooks/recommended",
       "standard"
     ],
     "parserOptions": {