This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
Prepare for Ignite 3 #151
Merged
Prepare for Ignite 3 #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Published 4.0.0-alpha.2. |
|
Published 4.0.0-alpha.3. |
filipac
reviewed
Apr 22, 2019
| @@ -230,6 +230,9 @@ async function install(context) { | |||
| ) | |||
| } catch (e) { | |||
| ignite.log(e) | |||
| print.error(' | |||
| There were errors when we were generating the project. Run with --debug to see verbose output. | |||
| ') | |||
| throw e | |||
There was a problem hiding this comment.
` should be used instead of regular quotes.
|
@jamonholmgren: Added pull request to fix the typo that @filipac commented on. |
infinitered-circleci
pushed a commit
that referenced
this pull request
May 3, 2019
# [4.0.0](v3.2.0...v4.0.0) (2019-05-03) ### Features * Ignite 3 compability ([#151](#151) by [@jamonholmgren](https://github.com/jamonholmgren), [@yulolimum](https://github.com/yulolimum), [@rmevans9](https://github.com/rmevans9), [@nirre7](https://github.com/nirre7)) ([25eaef0](25eaef0)) ### BREAKING CHANGES * Updated to be compatible with Ignite 3.0+
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: infinitered/ignite-andross#245
Ignite 3 is underway and the boilerplates will need to be upgraded to work with it. This PR brings Bowser into compatibility with Ignite 3.
Note that this will break Bowser for Ignite 2.x and prior.
Do not merge until Ignite 3 is deployed.