Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find locally installed plugins and display [Installed] if found #1471

Merged
merged 2 commits into from Oct 11, 2019
Merged

Find locally installed plugins and display [Installed] if found #1471

merged 2 commits into from Oct 11, 2019

Conversation

mikaoelitiana
Copy link
Contributor

@mikaoelitiana mikaoelitiana commented Oct 4, 2019 •
edited

Please verify the following:

  • Everything works on iOS/Android
  • yarn ci:test jest tests pass with new tests, if relevant
  • ./docs/ has been updated with your changes, if relevant

Describe your PR

Add [Installed] label if ignite plugin is installed when user launch ignite list

Fixes #1028

jamonholmgren
jamonholmgren requested changes Oct 4, 2019
View reviewed changes
Copy link
Member

@jamonholmgren jamonholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Check my comment and see how it goes.

src/lib/show-plugin-directory.ts Outdated Show resolved Hide resolved
@jamonholmgren jamonholmgren merged commit 94be03c into infinitered:master Oct 11, 2019
infinitered-circleci pushed a commit that referenced this pull request Oct 11, 2019
@semantic-release-bot
chore(release): 3.2.0 [skip ci]
95aa0ae 
# [3.2.0](v3.1.6...v3.2.0) (2019-10-11)

### Features

* **cli:** ignite doctor: find locally installed plugins and display [Installed] if found ([#1471](#1471) by [@mikaoelitiana](https://github.com/mikaoelitiana)) ([94be03c](94be03c))
@infinitered-circleci
Copy link

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamonholmgren jamonholmgren jamonholmgren approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI Needs A list option
3 participants
@mikaoelitiana @infinitered-circleci @jamonholmgren