Properly type Icon component icon prop as required #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mazenchami
approved these changes
Jul 11, 2022
infinitered-circleci
pushed a commit
that referenced
this pull request
Aug 10, 2022
## [7.14.2](v7.14.1...v7.14.2) (2022-08-10) ### Bug Fixes * **cli:** Handle "npm WARN" output in npm packager list command - fixes [#1993](#1993) ([#1998](#1998) by [@joshuayoes](https://github.com/joshuayoes)) ([07c1a01](07c1a01)) * **component:** Properly type Icon component icon prop as required ([#1976](#1976) by [@silasjmatson](https://github.com/silasjmatson)) ([524cb0d](524cb0d)) * **generator:** Added missing SnapshotIn import to model generator template ([#1986](#1986) by [@jojemapa](https://github.com/jojemapa)) ([d4d81ad](d4d81ad))
|
🎉 This PR is included in version 7.14.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn ci:testjest tests pass with new tests, if relevantREADME.mdhas been updated with your changes, if relevantDescribe your PR
The
Iconcomponent will do nothing without passing aniconprop to it. This corrects the prop types so thaticonis not marked optional