Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(boilerplate): podfile lock hermes version mismatch #2302

Merged
merged 1 commit into from Nov 14, 2022
Merged

fix(boilerplate): podfile lock hermes version mismatch #2302

merged 1 commit into from Nov 14, 2022

Conversation

frankcalise
Copy link
Contributor

@frankcalise frankcalise commented Nov 14, 2022 •
edited

Describe your PR

Concerns

The new command hits our pod install from bin/postInstall first which ends up bombing if things aren't correct. We should do one of the following:

  1. Copy the guts of npx pod-install into our postInstall script to automagically fix things
  2. Skip our initial pod install and let npx pod-install which we already run during new take care of business for igniting new apps (see fix(new-cmd): dedupe pod install running 2x #2284)
  3. Remove pod install from postInstall in favor of npx pod-install

@frankcalise frankcalise marked this pull request as ready for review November 14, 2022 13:49
@frankcalise frankcalise mentioned this pull request Nov 14, 2022
Closed
@jamonholmgren
Copy link
Member

I like options 2 and 3, to be honest. Replace with npx pod-install and dedup.

@jamonholmgren jamonholmgren mentioned this pull request Nov 14, 2022
Closed
@frankcalise frankcalise merged commit d47845e into master Nov 14, 2022
@frankcalise frankcalise deleted the fix/hermes-engine branch November 14, 2022 19:27
infinitered-circleci pushed a commit that referenced this pull request Nov 14, 2022
@semantic-release-bot
chore(release): 8.3.2 [skip ci]
9975a2b 
## [8.3.2](v8.3.1...v8.3.2) (2022-11-14)

### Bug Fixes

* **boilerplate:** podfile lock hermes version mismatch ([#2302](#2302)) ([d47845e](d47845e))
@infinitered-circleci
Copy link

🎉 This PR is included in version 8.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamonholmgren jamonholmgren jamonholmgren approved these changes

@yulolimum yulolimum Awaiting requested review from yulolimum

@joshuayoes joshuayoes Awaiting requested review from joshuayoes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ignite-cli new app failing at dependencies installation (expo-detox-hook/ExpoDetoxHook)
3 participants
@frankcalise @jamonholmgren @infinitered-circleci