In spacing should be same naming as in fonts

[ryskin]

That's really confusing in one place use extraLarge in another place it's just xl. I think naming is much more intuitive in fonts.

I propose adding more x ) like xxxs and xxxl, for extra small and extra big sizes.

The current demo really is the best of all time.

[yulolimum]

I like this proposal. I get confused between micro/tiny and huge/massive all the time. @robinheinze what do you think?

[jamonholmgren]

I don't have an opinion on which one is better, but I agree they should be consistent.

BTW, the as TextStyle doesn't do actual type-checking, just coerces/casts it as that.

I seem to remember some way to make a generic that would actually type-check when used as Only<Thing> or something, though?

[yulolimum]

@jamonholmgren

It doesn't do typechecking but it does typeahead:

You can do Record generic...

...but you lose the key union type that we have higher up in the component:

If you have a way to do both - would be great!

Let's open a new issue for that if you want.

[jamonholmgren]

Opened #2309 for that.

[robinheinze]

I'm totally fine if we want to change spacing scale to match the text size scale.

export const spacing = {
  xxxs: 2,
  xxs: 4,
  xs: 8,
  sm: 12,
  med: 16,
  lg: 24,
  xl: 32,
  xxl: 48,
  xxxl: 64,
} as const

[infinitered-circleci]

🎉 This issue has been resolved in version 8.8.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀