fix(cli): fixed frontmatter clean up in generate cmd

[frankcalise]

Please verify the following:

• yarn test jest tests pass with new tests, if relevant
• README.md has been updated with your changes, if relevant

Describe your PR

• Closes ignite-cli generate command leaves some unnecessary lines  #2325

[frankcalise]

@joshuayoes if you could review and test win/mac via npm link it would be appreciated :)

I ran through it but to double check

[joshuayoes]

@joshuayoes if you could review and test win/mac via npm link it would be appreciated :)

I ran through it but to double check

Yeah I can take a look at this tomorrow!

[joshuayoes]

I tried it on Windows, and it still had the same issue. Gluegun has a utility for end-of-line that I added, which I tested on Windows and Mac and seems to be working

[frankcalise]

I tried it on Windows, and it still had the same issue. Gluegun has a utility for end-of-line that I added, which I tested on Windows and Mac and seems to be working

Nice! yeah it looks like I committed a typo even, not sure why "n" was there, should have been empty quotes. I like your EOL fix though. Thanks!

[frankcalise]

@joshuayoes actually I still see the same issue, what shell are you running in Windows?

This is the only thing that I've seen working:
const NEW_LINE = process.platform === "win32" ? "" : "\n"

[joshuayoes]

I was running bash on windows, which may be giving me a false positive. I'll try again with powershell and cmd

[joshuayoes]

To link the CLI, I ran

yarn install
yarn build
npx link

And then to test, I ran

cd boilerplate
npx ignite-cli generate component Checkbox

On bash, powershell, and cmd on windows. I'm seeing the EOL fix working in all those shells on my machine

[infinitered-circleci]

🎉 This PR is included in version 8.4.5 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀