Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(boilerplate): updated web drawer layout width #2342

Merged
merged 2 commits into from Jan 3, 2023
Merged

fix(boilerplate): updated web drawer layout width #2342

merged 2 commits into from Jan 3, 2023

Conversation

frankcalise
Copy link
Contributor

@frankcalise frankcalise commented Dec 15, 2022 •
edited

Please verify the following:

  • yarn test jest tests pass with new tests, if relevant

Describe your PR

  • On super large displays, the DrawerLayout for web was still covering most of the entire window provided you weren't working with a maximized window. It now is 1/3 of the screen like a normal nav area on web

Graphics

Before

image

After

image

@frankcalise frankcalise marked this pull request as ready for review December 15, 2022 17:22
@frankcalise frankcalise merged commit 58de713 into master Jan 3, 2023
@frankcalise frankcalise deleted the fix/web-nav branch January 3, 2023 19:18
infinitered-circleci pushed a commit that referenced this pull request Jan 3, 2023
@semantic-release-bot
chore(release): 8.4.5 [skip ci]
7501739 
## [8.4.5](v8.4.4...v8.4.5) (2023-01-03)

### Bug Fixes

* **cli:** fixed frontmatter clean up in generate cmd ([#2328](#2328) by [@joshuayoes](https://github.com/joshuayoes) and [@frankcalise](https://github.com/frankcalise)) ([f4788f9](f4788f9))
* list item component to take children and add const assertion to colors ([#2337](#2337) by [@kateinkim](https://github.com/kateinkim)) ([7bdcec3](7bdcec3))
* **boilerplate:** updated web drawer layout width ([#2342](#2342) by [@frankcalise](https://github.com/frankcalise)) ([58de713](58de713))
* **screens:** ErrorBoundary invalid should update ([#2323](#2323) by [@tschai-yim](https://github.com/tschai-yim)) ([3952b69](3952b69))
@infinitered-circleci
Copy link

🎉 This PR is included in version 8.4.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@frankcalise @infinitered-circleci