Update Screen.tsx #2568
Merged
Update Screen.tsx #2568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the <KeyboardAvoidingView> component prop "behavior" as it was setting the non-ios value to "undefined" instead of "height". This was causing malfunctions on android devices and emulators.
|
@JenimDacket thanks for the contribution! Can you explain some test steps to me so I can verify it is working versus the old behavior for testing purposes? |
|
Ok I see the issue, the screen doesn't make the scroll adjustment so the keyboard isn't blocking the TextField with |
infinitered-circleci
pushed a commit
that referenced
this pull request
Nov 28, 2023
## [9.0.3](v9.0.2...v9.0.3) (2023-11-28) ### Bug Fixes * **boilerplate:** Android Screen keyboard behavior ([#2568](#2568) by @JenimDacket) ([c9311d1](c9311d1)) * **boilerplate:** flex property removed from tabbar label style ([#2569](#2569) by @Amarpsp10) ([200063f](200063f)) * **boilerplate:** rn 0.72.7 and expo 49.0.21 ([#2560](#2560) by [@frankcalise](https://github.com/frankcalise)) ([e9ad8b8](e9ad8b8))
|
🎉 This PR is included in version 9.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
That's correct! Sorry for the late response!
…On Tue, Nov 28, 2023, 06:20 Frank Calise ***@***.***> wrote:
Ok I see the issue, the screen doesn't make the scroll adjustment so the
keyboard isn't blocking the TextField with undefined versus height on
Android, tested it. Thanks!
—
Reply to this email directly, view it on GitHub
<#2568 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGHSAEFV5NBE7PWRIV45WHLYGXXJJAVCNFSM6AAAAAA7WZ2RY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRZHEZTOMBZGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the component prop "behavior" as it was setting the non-ios value to "undefined" instead of "height".
This was causing malfunctions on android devices and emulators.
Please verify the following:
yarn testjest tests pass with new tests, if relevantREADME.mdhas been updated with your changes, if relevantDescribe your PR
Updated the boilerplate component prop "behavior" as it was setting the non-ios value to "undefined" instead of "height".
This was causing malfunctions on android devices and emulators.