Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): remove expo-dev-client for Expo Go #2601

Merged
merged 1 commit into from Jan 6, 2024

Conversation

frankcalise
Copy link
Contributor

Describe your PR

Tested locally with:

ignite/bin/ignite new ignite-dev-client --yes
cd ignite-dev-client
# nothing found here
cat package.json|grep "expo-dev-client"
# boots up without error
yarn ios

Copy link
Member

@jamonholmgren jamonholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough!

Copy link
Contributor

@morganick morganick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 and works as expected. Tested both ExpoGo and Expo Prebuild.

@frankcalise frankcalise merged commit cf6154e into master Jan 6, 2024
1 check passed
@frankcalise frankcalise deleted the fix/2600-expo-dev-client branch January 6, 2024 20:09
infinitered-circleci pushed a commit that referenced this pull request Jan 6, 2024
## [9.3.1](v9.3.0...v9.3.1) (2024-01-06)

### Bug Fixes

* **cli:** remove expo-dev-client for Expo Go ([#2601](#2601) by [@frankcalise](https://github.com/frankcalise)) ([cf6154e](cf6154e))
@infinitered-circleci
Copy link

🎉 This PR is included in version 9.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expo Go should not install expo-dev-client
4 participants