New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback Locale #2611
Fallback Locale #2611
Conversation
@@ -34,6 +34,11 @@ jest.mock("i18n-js", () => ({ | |||
}, | |||
})) | |||
|
|||
jest.mock("expo-localization", () => ({ | |||
...jest.requireActual("expo-localization"), | |||
getLocales: () => [{ languageTag: "en-US", textDirection: "ltr" }], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
although expo-localization
returns getLocales
, it returns an empty array. setting a default here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks for this!
## [9.4.1](v9.4.0...v9.4.1) (2024-01-23) ### Bug Fixes * Fallback Locale ([#2611](#2611) by [@sergioisidoro](https://github.com/sergioisidoro) [@mazenchami](https://github.com/mazenchami)) ([0f2892a](0f2892a))
🎉 This PR is included in version 9.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Please verify the following:
yarn test
jest tests pass with new tests, if relevantREADME.md
has been updated with your changes, if relevantDescribe your PR
#2414