Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add prebuild:clean to splash screen gen output #2665

Merged
merged 1 commit into from Apr 14, 2024
Merged

add prebuild:clean to splash screen gen output #2665

merged 1 commit into from Apr 14, 2024

Conversation

Parrryy
Copy link
Contributor

@Parrryy Parrryy commented Apr 11, 2024

Please verify the following:

  • [ x ] yarn test jest tests pass with new tests, if relevant
  • [ x ] yarn lint eslint checks pass with new code, if relevant
  • [ x ] yarn format:check prettier checks pass with new code, if relevant
  • [ x ] README.md (or relevant documentation) has been updated with your changes

Describe your PR

Update the output of a splash screen generator to notify users they should run prebuild:clean command to ensure their changes are reflected.

frankcalise
frankcalise approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@frankcalise frankcalise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@frankcalise frankcalise merged commit 725c4e5 into infinitered:master Apr 14, 2024
1 check passed
infinitered-circleci pushed a commit that referenced this pull request Apr 14, 2024
@semantic-release-bot
chore(release): 9.6.3 [skip ci]
527b9f5 
## [9.6.3](v9.6.2...v9.6.3) (2024-04-14)

### Bug Fixes

* **boilerplate:** doc url ([#2658](#2658) by @HalfAkilo) ([7111bf7](7111bf7))
* **cli:** add prebuild:clean to splash screen gen output ([#2665](#2665) by @Parrryy) ([725c4e5](725c4e5))
@infinitered-circleci
Copy link

🎉 This PR is included in version 9.6.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markrickert markrickert markrickert approved these changes

@frankcalise frankcalise frankcalise approved these changes

@jamonholmgren jamonholmgren jamonholmgren approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Parrryy @infinitered-circleci @markrickert @frankcalise @jamonholmgren