Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nice Feature Idea - Scrub GIF #79

Closed
GantMan opened this issue Apr 4, 2019 · 8 comments
Closed

Nice Feature Idea - Scrub GIF #79

GantMan opened this issue Apr 4, 2019 · 8 comments
Labels
enhancement New feature or request

Comments

@GantMan
Copy link
Member

GantMan commented Apr 4, 2019

It would be pretty cool if when you scubbed the victory bar for a GIF, the associated GIF frame was shown. This can happen by having an option passed in for a reference to the SuperGIF and then using move_to(index). If you don't want the supergif, it's set to NULL in memory like it is currently.

I'd love to see why a particular frame is misclassified!

@GantMan
Copy link
Member Author

GantMan commented Apr 4, 2019

@xilaraux - sorry I took your last ticket, would you want this one?

@GantMan GantMan added the enhancement New feature or request label Apr 4, 2019
@xilaraux
Copy link
Contributor

xilaraux commented Apr 5, 2019

@GantMan don't be sorry :)
I can handle it, but it will take a while for me.

@GantMan
Copy link
Member Author

GantMan commented Apr 5, 2019

Awesome! Off the top of my head here's a simple implementation:

TADAAAAAAA 🎉

@xilaraux
Copy link
Contributor

xilaraux commented Apr 5, 2019

You almost did it.
I will implement it. :)
I don't understand one thing. Should the frame be displayed next to this text or somewhat separately?

@GantMan
Copy link
Member Author

GantMan commented Apr 6, 2019

Hahahaha.

So I think if you call GifReference.move_to(i) the GIF they dropped will lock to that frame. No need to show it anywhere. Basically it will stop animating and move to that frame. I think.... :) Once you start experimenting it should be clear. Then when you stop mousing over the graph, it would be cool if it went back to animating.

@GantMan
Copy link
Member Author

GantMan commented Apr 14, 2019

@xilaraux - how goes it?

@xilaraux
Copy link
Contributor

xilaraux commented Apr 15, 2019

@GantMan
You can see the progress here - #83
I want to propose to name SuperGif object as gifControl and setGitControl and prop in config. What do you think?
Also, I have doubts about the way I am setting this object and saving if to the React state, but spoiling the window is not an option neither.
Looking forward to your review :)
Sorry for the delay.

@GantMan
Copy link
Member Author

GantMan commented Apr 19, 2019

Looks great, I updated your contributor status in the readme: 5413bd0

@GantMan GantMan closed this as completed Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants