Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrub GIF. #83

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Scrub GIF. #83

merged 1 commit into from
Apr 19, 2019

Conversation

xilaraux
Copy link
Contributor

No description provided.

@xilaraux xilaraux force-pushed the feature/scrub-gif branch 3 times, most recently from 866925c to bf80747 Compare April 15, 2019 19:12
@xilaraux xilaraux changed the title WIP: Scrup GIF. Scrup GIF. Apr 15, 2019
@xilaraux xilaraux changed the title Scrup GIF. Scrub GIF. Apr 15, 2019
@xilaraux xilaraux mentioned this pull request Apr 15, 2019
Closed
GantMan
GantMan approved these changes Apr 19, 2019
View reviewed changes
Copy link
Member

@GantMan GantMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic. We could have cleaned up the pass props with context, but 1 layer deep isn't bad. I think this looks perfect!

@GantMan GantMan merged commit 5c1b915 into infinitered:master Apr 19, 2019
@GantMan
Copy link
Member

GantMan commented Apr 19, 2019

Awesome add @xilaraux - I spoke on this library yesterday and thanked all the contributors. Great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GantMan GantMan GantMan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xilaraux @GantMan