Validations: localhost as a valid url

[vaughankg]

rmq.validation.valid?("http://localhost", :url) #=> false

Is this a desired behavior?

Thanks all for creating rmq :)

[willrax]

I don't think the regex would consider http://localhost a legitimate url. You would need a .tld on the end of it.

[GantMan]

Hrmmmm, I agree it's not really a valid URL. But I also see how it can be an issue. Consider the following suggestions for something we should add: What would be best for RMQ users?

# this would be the quick fix, to add some simple shotcircuit
rmq.validation.valid?("http://localhost", :url, localhost: true) #=> true 

# Then again... this would be interesting
rmq.validation.valid?("http://localhost", :url, white_list: ["http://localhost", "https://localhost"]) #=> true

# but then maybe whitelist should be for ANY validation?
rmq.validation.valid?("ZERO", :number, white_list: ["ZERO"]) #=> true

thoughts?

[willrax]

Whitelist, whitelist, whitelist! I like the white list idea.

[vaughankg]

The white_list is definitely nice and flexible although in this case I'd really want to validate localhost + any port number -- which would be impractical.

[twerth]

+1 on white_list

[willrax]

Is this just while in development or is it something you'll be deploying? Would this help: #106 ?

[vaughankg]

@willrax It's something that I'll be deploying, where the user gets to specify an API end point to hit. A custom validation as per #106 definitely solves for my use case.

[GantMan]

added the white_list feature. We'll attack the custom regex feature next (maybe tomorrow) 👍 ❓

[GantMan]

Documented: http://rubymotionquery.com/document/validation-with-rmq/

[GantMan]

closed via #107, #108, #109