Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fl for from_left and fr for from_right, but nothing between #152

Closed
GantMan opened this issue Dec 3, 2014 · 1 comment
Closed

fl for from_left and fr for from_right, but nothing between #152

GantMan opened this issue Dec 3, 2014 · 1 comment

Comments

@GantMan
Copy link
Member

GantMan commented Dec 3, 2014

Frame settings of left and right can sometimes be thought of as from_leftbut fl will silently fail.

This issue is 2 fold:

  • First, add our friendly aliases for fl
  • Second, stop being silent and throw a warning when we get strange frame demands

The check for strange frame keys should be extremely performant

@GantMan
Copy link
Member Author

GantMan commented Dec 3, 2014

@twerth says this should throw a warning, not an exception. Original edited.

GantMan added a commit to GantMan/rmq that referenced this issue Dec 3, 2014
GantMan added a commit to GantMan/rmq that referenced this issue Dec 3, 2014
GantMan added a commit to GantMan/rmq that referenced this issue Dec 3, 2014
GantMan added a commit that referenced this issue Dec 4, 2014
assessing issue #152 - added `fl` and warning
@GantMan GantMan closed this as completed Dec 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant