Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle bad Node.js version proposal. #45

Conversation

mattathompson
Copy link
Contributor

Update bin/solidarity w/ logic for handling bad. #42

Here is an example of the message when given a bad node version:
screen shot 2017-10-08 at 11 17 32 pm

@mattathompson mattathompson changed the title Handle bad Node.js proposal. Handle bad Node.js version proposal. Oct 9, 2017
@GantMan GantMan mentioned this pull request Oct 9, 2017
bin/solidarity Outdated
@@ -1,3 +1,14 @@
#!/usr/bin/env node
// let's kick it off with the command line parameters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any chance you can move this comment down to right above line 7?

@mattathompson
Copy link
Contributor Author

@GantMan done.

Copy link
Member

@GantMan GantMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GantMan GantMan merged commit baa6862 into infinitered:master Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants