Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix position of QuickFix failure viewer dialog #256

Merged
merged 2 commits into from
May 23, 2018

Conversation

sarod
Copy link
Member

@sarod sarod commented May 23, 2018

fixes #255

@codecov-io
Copy link

codecov-io commented May 23, 2018

Codecov Report

Merging #256 into master will decrease coverage by <.01%.
The diff coverage is 40%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #256      +/-   ##
============================================
- Coverage     73.07%   73.07%   -0.01%     
- Complexity     1223     1224       +1     
============================================
  Files           182      182              
  Lines          3993     3996       +3     
  Branches        298      298              
============================================
+ Hits           2918     2920       +2     
- Misses          979      980       +1     
  Partials         96       96
Impacted Files Coverage Δ Complexity Δ
...test/eclipse/resolution/ErrorViewerResolution.java 45.45% <0%> (ø) 3 <0> (ø) ⬇️
...g/infinitest/eclipse/resolution/FailureViewer.java 83.67% <54.54%> (-1.11%) 7 <2> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47a3ea7...2bdb284. Read the comment docs.

@sarod sarod force-pushed the fix-255-failure-viewer-position branch from e34a16c to 4b4ad86 Compare May 23, 2018 21:09
@sarod sarod merged commit e6b1a28 into master May 23, 2018
@sarod sarod deleted the fix-255-failure-viewer-position branch May 31, 2018 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[infinitest-eclipse] Quick fix dialog should open centered in current window.
2 participants