java18 compatibility #295
Merged
java18 compatibility #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
- add javax.annotation as dependency, tests passing also for java 8 - upgrade maven plugins to be Java 11 compatible Signed-off-by: Aurélien Pupier <apupier@redhat.com>
error was:both interface com.intellij.openapi.module.Module in com.intellij.openapi.module and class java.lang.Module in java.lang match Signed-off-by: Aurélien Pupier <apupier@redhat.com>
fixing java 11 error: [ERROR] /C:/git/infinitest/infinitest-intellij/src/main/java/org/infinitest/intellij/InfinitestJarsLocator.java:[84,28] getPrefixes(java.lang.String) in org.infinitest.intellij.PomNamespaceContext cannot implement getPrefixes(java.lang.String) in javax.xml.namespace.NamespaceContext return type java.util.Iterator<?> is not compatible with java.util.Iterator<java.lang.String> [ERROR] /C:/git/infinitest/infinitest-intellij/src/main/java/org/infinitest/intellij/InfinitestJarsLocator.java:[83,9] method does not override or implement a method from a supertype Signed-off-by: Aurélien Pupier <apupier@redhat.com>
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
…pr-Java18-compatibility
Upgraded Jacoco for Java 18 compatibility
The stacktrace for reflective constructor calls changed between java 11 and 17 and again in Java 18. Adjust the stackelement we're looking for depending on the version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on the unmerged #271 and adds compatibility with Java 18