Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support for JUnit 5 combined annotations #302

Merged
merged 2 commits into from
Aug 1, 2022

Conversation

gtoison
Copy link
Contributor

@gtoison gtoison commented Aug 1, 2022

Adds support for JUnit5 combined annotation: https://junit.org/junit5/docs/current/user-guide/#writing-tests-meta-annotations

  • When checking if a method is a test, look for combined annotations
  • Look for annotations that are themselves annotated with TestTemplate to support ParameterizedTest
  • Added sample classes covering the new cases

Fixes #276
Fixes #268

- When checking if a method is a test, look for combined annotations
- Look for annotations that are themselves annotated with TestTemplate
to support ParameterizedTest
- Added sample classes covering the new cases

Fixes #276
Fixes #268
Copy link
Member

@apupier apupier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is implemented fro IntelliJ only, right?
For Eclipse more work will need to be done or it is already supported?

EDIT: please forget about this comment, I read too fast.

@gtoison
Copy link
Contributor Author

gtoison commented Aug 1, 2022

This should work for both plugins since the change is in the shared infinitest-lib module
I still need to find a practical way to test the plugins though

@gtoison gtoison merged commit 00647f1 into master Aug 1, 2022
@gtoison gtoison deleted the pr-combined-annotation-support branch April 15, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@ParameterizedTest not detected as test Please support JUnit 5 Tags as composed annotations
2 participants