Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade JUnit5 to 5.9.1 #352

Merged
merged 1 commit into from
Oct 22, 2022
Merged

deps: upgrade JUnit5 to 5.9.1 #352

merged 1 commit into from
Oct 22, 2022

Conversation

gtoison
Copy link
Contributor

@gtoison gtoison commented Oct 22, 2022

  • We need to upgrade JUnit5 so we can use @timeout and @tempdir in Infinitest's own tests, so upgrade it to the latest version
  • Unpacking the runner dependencies in the classes folder during the compile phase causes JUnit5 classes to be available from different locations (the classes folder and the jars), this fails with JPMS. It is also britle because we need to list the dependencies explicitely. So we shade dependencies instead of unpacking them
  • Felix breaks with module-info.java due to FELIX-5698 so we upgrade it to the latest

@gtoison
deps: upgrade JUnit5 to 5.9.1
ae5206b 
- We need to upgrade JUnit5 so we can use @timeout and @tempdir in
Infinitest's own tests, so upgrade it to the latest version
- Unpacking the runner dependencies in the classes folder during the
compile phase causes JUnit5 classes to be available from different
locations (the classes folder and the jars), this fails with JPMS. It is
also britle because we need to list the dependencies explicitely. So we
shade dependencies instead of unpacking them
- Felix breaks with module-info.java due to FELIX-5698 so we upgrade it
to the latest
@gtoison gtoison added comp:core core feature of infinitest (infinitest-lib + infinitest-runner)) dependencies Pull requests that update a dependency file labels Oct 22, 2022
@gtoison gtoison merged commit 8b99e3b into master Oct 22, 2022
@gtoison gtoison deleted the pr-upgrade-junit5-to-5.9.1 branch October 22, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comp:core core feature of infinitest (infinitest-lib + infinitest-runner)) dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@gtoison