Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set the core name from the constructor instead of a setter #358

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

gtoison
Copy link
Contributor

@gtoison gtoison commented Oct 26, 2022

we always seem to call setName() after the constructor, so add an argument to the constructor instead so we can add the core name to the error message
see #357

we always seem to call setName() after the constructor, so add an
argument to the constructor instead so we can add the core name to the
error message
see #357
@gtoison gtoison marked this pull request as ready for review October 26, 2022 17:27
@gtoison gtoison merged commit 34d01e7 into master Oct 26, 2022
@gtoison gtoison deleted the pr-set-core-name-from-constructor branch October 26, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant