-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: check the compatibility of the intellij plugin #377
Conversation
.github/workflows/build.yml
Outdated
@@ -36,6 +36,16 @@ jobs: | |||
# We need a virtual X11 for the Eclipse unit tests | |||
run: | | |||
xvfb-run -a mvn -B test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should probably have package
instead of test
to have the dist.zip built, to avoid:
ls: /github/workspace/infinitest-intellij/target/infinitest-intellij-*-dist.zip: No such file or directory
(I don't know, if directories are automatically propagated across the CI "stages")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing!
In retrospect this is quite obvious but at the same time I was completely off track on that one... Thanks!
plugin-location: 'infinitest-intellij/target/infinitest-intellij-*-dist.zip' | ||
ide-versions: | | ||
ideaIC:2020.1.4 | ||
ideaIC:LATEST-EAP-SNAPSHOT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add here also the latest stable version - to be able to faster distinguish if the problem is with the latest Idea EAP snapshot or with the changes in Infinitest you're just committed.
Btw, a nice concept. I didn't know that plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thank you!
No description provided.