Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: check the compatibility of the intellij plugin #377

Merged
merged 4 commits into from
Mar 22, 2023

Conversation

gtoison
Copy link
Contributor

@gtoison gtoison commented Feb 18, 2023

No description provided.

@gtoison gtoison added comp:infinitest-intellij Issues related to Infintest for IntelliJ (and other Jetbrains IDEs) comp:build things relative to build,packaging and release process labels Feb 18, 2023
@@ -36,6 +36,16 @@ jobs:
# We need a virtual X11 for the Eclipse unit tests
run: |
xvfb-run -a mvn -B test
Copy link
Contributor

@szpak szpak Mar 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably have package instead of test to have the dist.zip built, to avoid:

ls: /github/workspace/infinitest-intellij/target/infinitest-intellij-*-dist.zip: No such file or directory

(I don't know, if directories are automatically propagated across the CI "stages")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing!
In retrospect this is quite obvious but at the same time I was completely off track on that one... Thanks!

plugin-location: 'infinitest-intellij/target/infinitest-intellij-*-dist.zip'
ide-versions: |
ideaIC:2020.1.4
ideaIC:LATEST-EAP-SNAPSHOT
Copy link
Contributor

@szpak szpak Mar 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add here also the latest stable version - to be able to faster distinguish if the problem is with the latest Idea EAP snapshot or with the changes in Infinitest you're just committed.

Btw, a nice concept. I didn't know that plugin.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thank you!

@gtoison gtoison merged commit 3c868cb into master Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:build things relative to build,packaging and release process comp:infinitest-intellij Issues related to Infintest for IntelliJ (and other Jetbrains IDEs)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants