Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: we shouldn't run tests on a module with no JDK #384

Merged
merged 3 commits into from
Feb 27, 2023

Conversation

gtoison
Copy link
Contributor

@gtoison gtoison commented Feb 26, 2023

When opening a project with no JDK (e.g. a javascript project) we try to build the results tree and this fails when we try to get the RuntimeEnvironment of the module.

When opening a project with no JDK (e.g. a javascript project) we try to
build the results tree and this fails when we try to get the
RuntimeEnvironment of the module.
@gtoison gtoison added type: bug comp:infinitest-intellij Issues related to Infintest for IntelliJ (and other Jetbrains IDEs) labels Feb 26, 2023
@fatso83
Copy link

fatso83 commented Feb 27, 2023

Verified:
rm -r infinitest-jdk-error/; unzip ~/Nedlastinger/repro.zip; intellij-idea-ultimate infinitest-jdk-error/ resulted in 0 errors 🥳

I do not know why Sonar fails apart from SONAR_TOKEN being missing, but I suspect it is down to the forked repo.

@gtoison
Copy link
Contributor Author

gtoison commented Feb 27, 2023

Thanks for testing!
Yes, you're right, the Sonar check fails because the forked repo does not have the token

@gtoison gtoison merged commit a937de5 into infinitest:master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:infinitest-intellij Issues related to Infintest for IntelliJ (and other Jetbrains IDEs) type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants