fix: stop using project components and constructor injection #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InfinitestHighlightingPassFactory is declared as a project component and these should be migrated to services. The Jetbrains marketplace flagged that is uses constructor injection and refused the new version of the plugin. Since we need it to register from somewhere create it in the InfinitestToolWindowFactory
gtoison
added
the
comp:infinitest-intellij
|
Hello @szpak , this seems to work fine but it would be great if you could try out that change! |
|
I gave it a quick try and it seems to work in my reference project. |
|
Thanks a lot for testing, I didn't want to break things |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InfinitestHighlightingPassFactory is declared as a project component and these should be migrated to services. The Jetbrains marketplace flagged that it uses constructor injection and refused the new version of the plugin.
Since we need it to register from somewhere, create it in the InfinitestToolWindowFactory
Fixes #401