Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor enhancement #2

Merged
merged 3 commits into from
Mar 16, 2018
Merged

minor enhancement #2

merged 3 commits into from
Mar 16, 2018

Conversation

Sispheor
Copy link
Contributor

@Sispheor Sispheor commented Dec 4, 2017

Hi, thanks for your exporter. I've updated a couple thing. I don't know if you are interested by implementing them into your project.

  • refactor the code to accept only http call like a backbox exporter
  • code hardening/cleanup
  • add Prometheus config example
  • add labels: product_name and server_name.
  • endpoint can be precised. default to /metrics
  • add firmware version gauge

@Rucknar Rucknar requested a review from joeds13 December 4, 2017 16:39
@Sispheor
Copy link
Contributor Author

up ! :)

@Rucknar
Copy link
Contributor

Rucknar commented Feb 14, 2018

@joeds13 One for you Joe!

@Sispheor
Copy link
Contributor Author

It's just because I just received a PR on my fork. I think it would be better if you keep the lead on the project.

* Compatibility with older iLO versions

* Update README repository info

* Changed default port to 9100

* Changed default port to the one registered at https://github.com/prometheus/prometheus/wiki/Default-port-allocations
Updated README with metics output from older iLO devices
@fredericve
Copy link

I tested this PR on a number of our servers. Seems to work fine! thanks.

Copy link
Contributor

@joeds13 joeds13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joeds13 joeds13 merged commit 05f6e71 into infinityworks:master Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants