Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/update test error messages #102

Closed
wants to merge 2 commits into from
Closed

Fix/update test error messages #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6962f7c
Update error message in core-ts package
gbareza Mar 29, 2023
f9701b7
Update error message for react-js package
gbareza Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/eslint-config-core-ts/__tests__/array-type.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ test('should disallow array style for readonly array definitions', () =>
`
const y: readonly string[] = ['a', 'b'];
`,
["Array type using 'string[]' is forbidden. Use 'Array<string>' instead."]
["Array type using 'readonly string[]' is forbidden. Use 'ReadonlyArray<string>' instead."]
));

test.run();
4 changes: 2 additions & 2 deletions packages/eslint-config-react-js/__tests__/jsx-a11y-anchor-is-valid.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const { validate } = getTester({

const test = suite(rule);

const anchorUsedAsButtonError = `Anchor used as a button. Anchors are primarily expected to navigate. Use the button element instead. Learn more: https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/anchor-is-valid.md`;
const anchorUsedAsButtonError = `Anchor used as a button. Anchors are primarily expected to navigate. Use the button element instead. Learn more: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/HEAD/docs/rules/anchor-is-valid.md`;

test(`should allow with warning the use of anchors element as a button (1)`, () =>
validate(
Expand Down Expand Up @@ -102,7 +102,7 @@ test(`should allow with warning the use of invalid href attributes in anchor ele
`,
[],
[
`The href attribute requires a valid value to be accessible. Provide a valid, navigable address as the href value. If you cannot provide a valid href, but still need the element to resemble a link, use a button and change it with appropriate styles. Learn more: https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/anchor-is-valid.md`,
`The href attribute requires a valid value to be accessible. Provide a valid, navigable address as the href value. If you cannot provide a valid href, but still need the element to resemble a link, use a button and change it with appropriate styles. Learn more: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/HEAD/docs/rules/anchor-is-valid.md`,
]
));

Expand Down