New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RefCell wrapper from NativeFluvioClient #44

Merged

simlay merged 1 commit into infinyon:main from nicholastmosher:remove-refcell

Jun 19, 2021

Contributor

nicholastmosher commented Jun 19, 2021

Closes #42 by getting rid of RefCell that was causing panics during multiple borrows.

This is a followup to Relax mutability requirements for Fluvio Admin client fluvio#1178 for making the FluvioAdmin client methods take &self rather than &mut self, meaning that we no longer need a RefCell to get mutable access.


          Remove RefCell wrapper from NativeFluvioClient

2d39169

nicholastmosher requested a review from simlay

June 19, 2021 00:31

simlay merged commit 876f075 into infinyon:main

nicholastmosher deleted the remove-refcell branch

June 21, 2021 10:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment