fix: properly handle produce operation failure (#3405)

The failure of produce operation was mistakenly treated as a failure of the transportation layer, which is not. That led to non-helpful error reporting to the user: ```bash Producer error: failed to get record metadata ``` Fixed by not handling return error code too early.
infinyon · Jul 21, 2023 · 63f9562 · 63f9562
1 parent c191226
commit 63f9562
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 7 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/fluvio/Cargo.toml b/crates/fluvio/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "fluvio"
-version = "0.19.3"
+version = "0.19.4"
 edition = "2021"
 license = "Apache-2.0"
 authors = ["Fluvio Contributors <team@fluvio.io>"]

diff --git a/crates/fluvio/src/producer/partition_producer.rs b/crates/fluvio/src/producer/partition_producer.rs
@@ -280,11 +280,6 @@ impl PartitionProducer {
                 let mut futures = Vec::with_capacity(partition_count);
                 for topic in produce_response.responses.into_iter() {
                     for partition in topic.partitions {
-                        if partition.error_code.is_error() {
-                            return Err(FluvioError::from(ProducerError::from(
-                                partition.error_code,
-                            )));
-                        }
                         futures.push(ProducePartitionResponseFuture::ready(
                             partition.base_offset,
                             partition.error_code,