Skip to content

Commit

Permalink
feat: re-export 'retry' in common connector crate (#2922)
Browse files Browse the repository at this point in the history
  • Loading branch information
Alexander Galibey committed Jan 11, 2023
1 parent 0b4486a commit ae47fe0
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions crates/fluvio-connector-common/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ pub type Result<T> = std::result::Result<T, Error>;
pub mod future {
pub use fluvio_future::task::run_block_on;
pub use fluvio_future::subscriber::init_logger;
pub use fluvio_future::retry;
}

pub mod tracing {
Expand Down
2 changes: 1 addition & 1 deletion crates/fluvio-connector-derive/src/generator.rs
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ pub(crate) fn generate_connector_config(item: &ConnectorConfigStruct) -> TokenSt
#config_struct

impl #ident {
fn __config_name() -> &'static str {
pub fn __config_name() -> &'static str {
#config_name
}
}
Expand Down
2 changes: 1 addition & 1 deletion crates/fluvio/src/producer/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ impl Iterator for RetryPolicyIter {
}

impl RetryPolicy {
pub(crate) fn iter(&self) -> impl Iterator<Item = Duration> + Debug + Send {
pub fn iter(&self) -> impl Iterator<Item = Duration> + Debug + Send {
match self.strategy {
RetryStrategy::FixedDelay => {
RetryPolicyIter::FixedDelay(FixedDelay::new(self.initial_delay))
Expand Down

2 comments on commit ae47fe0

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: ae47fe0 Previous: 0b4486a Ratio
encode wasm file 316040 ns/iter (± 34974) 297972 ns/iter (± 20864) 1.06

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: ae47fe0 Previous: 0b4486a Ratio
vecu8 encoding 326470 ns/iter (± 738881) 336571 ns/iter (± 765963) 0.97
vecu8 decoding 446838 ns/iter (± 270) 622099 ns/iter (± 3998) 0.72
bytebuf encoding 7161 ns/iter (± 60) 7669 ns/iter (± 3) 0.93
bytebuf decoding 7041 ns/iter (± 85) 7602 ns/iter (± 31) 0.93

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.