Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Add cluster shutdown #2912

Closed
wants to merge 4 commits into from

Conversation

crajcan
Copy link
Contributor

@crajcan crajcan commented Jan 4, 2023

@crajcan crajcan changed the title Add cluster shutdown feat: Add cluster shutdown Jan 4, 2023
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Couple of comments

crates/fluvio-cluster/src/cli/shutdown.rs Outdated Show resolved Hide resolved
crates/fluvio-cluster/src/cli/shutdown.rs Outdated Show resolved Hide resolved
@crajcan
Copy link
Contributor Author

crajcan commented Jan 5, 2023

I made the requested changes, although I'm still unsure how to get cluster upgrade to work in this context:

./fluvio λ: flvd cluster shutdown --local
Removed spu monitoring socket: /tmp/fluvio-spu.sock
Uninstalled fluvio local components

./fluvio λ: flvd cluster upgrade --local --develop
local: true
📝 Running pre-flight checks
    ✅ Supported helm version 3.9.4+gdbc6d8e is installed
    ✅ Kubectl active cluster rancher-desktop at: https://127.0.0.1:6443 found
    ✅ Supported Kubernetes server 1.24.6+k3s1 found
    ✅ Local Fluvio is not installed
    ✅ Fluvio system charts are installed
🎉 All checks passed!
✅ Local Cluster initialized
✅ SC Launched
👤 Profile set
Error: 
   0: Fluvio cluster error
   1: Kubernetes client error
   2: MetaStatus {
   2:     api_version: "v1",
   2:     code: Some(
   2:         409,
   2:     ),
   2:     details: Some(
   2:         StatusDetails {
   2:             name: "custom-spu-5001",
   2:             group: Some(
   2:                 "fluvio.infinyon.com",
   2:             ),
   2:             kind: "spus",
   2:             uid: None,
   2:         },
   2:     ),
   2:     kind: "Status",
   2:     message: Some(
   2:         "spus.fluvio.infinyon.com \"custom-spu-5001\" already exists",
   2:     ),
   2:     reason: Some(
   2:         "AlreadyExists",
   2:     ),
   2:     status: FAILURE,
   2: }

@sehz
Copy link
Contributor

sehz commented Jan 5, 2023

For upgrading, let's execute on separate PR. For now, can manually start SC and SPU for the local cluster.

To upgrade, general strategy is to use an idempotent operation.

Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for PR

@sehz sehz linked an issue Jan 5, 2023 that may be closed by this pull request
@sehz sehz added this to the 0.10.4 milestone Jan 5, 2023
@sehz sehz added the cluster label Jan 5, 2023
@sehz sehz linked an issue Jan 5, 2023 that may be closed by this pull request
@sehz
Copy link
Contributor

sehz commented Jan 5, 2023

works great!

@sehz
Copy link
Contributor

sehz commented Jan 5, 2023

bors r+

bors bot pushed a commit that referenced this pull request Jan 5, 2023
@bors
Copy link

bors bot commented Jan 5, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: Add cluster shutdown [Merged by Bors] - feat: Add cluster shutdown Jan 5, 2023
@bors bors bot closed this Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: cluster shutdown command for local
2 participants