-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: Add cluster shutdown #2912
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Couple of comments
I made the requested changes, although I'm still unsure how to get
|
For upgrading, let's execute on separate PR. For now, can manually start SC and SPU for the local cluster. To upgrade, general strategy is to use an idempotent operation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for PR
works great! |
bors r+ |
Pull request successfully merged into master. Build succeeded: |
#2911