[Merged by Bors] - feat(cdk): add -p package_name in cdk publish
#3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The search assumption sounds reasonable to me. |
digikata
approved these changes
Mar 23, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 23, 2023
Currently, `cdk publish` command does not have the option to specify the package; hence must be executed from the crate's directory. It is inconvenient in CI/CD pipelines. This PR adds the support `-p` parameter so the command can be executed from any workspace directory. This includes how files listed `package-meta.yaml` are searched: now they are looked up relative to the file `package-meta.yaml` itself instead of the current directory where `cdk` runs.
|
Build failed: |
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Mar 24, 2023
Currently, `cdk publish` command does not have the option to specify the package; hence must be executed from the crate's directory. It is inconvenient in CI/CD pipelines. This PR adds the support `-p` parameter so the command can be executed from any workspace directory. This includes how files listed `package-meta.yaml` are searched: now they are looked up relative to the file `package-meta.yaml` itself instead of the current directory where `cdk` runs.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
-p package_name in cdk publish-p package_name in cdk publish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
cdk publishcommand does not have the option to specify the package; hence must be executed from the crate's directory. It is inconvenient in CI/CD pipelines.This PR adds the support
-pparameter so the command can be executed from any workspace directory.This includes how files listed
package-meta.yamlare searched: now they are looked up relative to the filepackage-meta.yamlitself instead of the current directory wherecdkruns.