Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: disable default fluvio features for sdk #3098

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore: disable default fluvio features for sdk #3098

wants to merge 1 commit into from

Conversation

galibey
Copy link
Contributor

@galibey galibey commented Mar 23, 2023

fluvio-connector-common activates openssl feature for fluvio crate without the actual need for that, and this prevents users from choosing if they want this feature for fluvio.

@galibey galibey requested a review from sehz March 23, 2023 17:37
@galibey galibey self-assigned this Mar 23, 2023
@galibey galibey added this to the 0.10.6 milestone Mar 23, 2023
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@galibey
Copy link
Contributor Author

galibey commented Mar 23, 2023

bors r+

bors bot pushed a commit that referenced this pull request Mar 23, 2023
`fluvio-connector-common` activates `openssl` feature for `fluvio` crate without the actual need for that, and this prevents users from choosing if they want this feature for `fluvio`.
@bors
Copy link

bors bot commented Mar 23, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore: disable default fluvio features for sdk [Merged by Bors] - chore: disable default fluvio features for sdk Mar 23, 2023
@bors bors bot closed this Mar 23, 2023
@galibey galibey deleted the feat/disable-default-features-in-connectors-common branch March 23, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants