[Merged by Bors] - feat: cleanup after publishing packages #3259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sehz
requested changes
May 15, 2023
|
@sehz I'm starting to find many similar aspects in both CLIs, starting to think about a common set of functions we could put together and reuse for both. Of course in future iterations! |
EstebanBorai
commented
May 15, 2023
Comment on lines
+105
to
+107
| if !self.pack { | ||
| self.cleanup(&package_info)?; | ||
| } |
There was a problem hiding this comment.
Instead of calling separately, we skip running the cleanup if the --pack argument is not present.
This way we always cleanup unless specified.
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 15, 2023
Removes `.hub` directory after publishing packages to the Hub when using both **cdk** or **smdk**.
|
Build failed: |
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
May 15, 2023
Removes `.hub` directory after publishing packages to the Hub when using both **cdk** or **smdk**.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
.hubdirectory after publishing packagesto the Hub when using both cdk or smdk.