Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDK | Cleanup after Publishing #3253

Closed
EstebanBorai opened this issue May 12, 2023 · 3 comments
Closed

CDK | Cleanup after Publishing #3253

EstebanBorai opened this issue May 12, 2023 · 3 comments
Assignees
Labels
DX/CDK Connector Developer Kit
Milestone

Comments

@EstebanBorai
Copy link
Contributor

After cdk publish is done, we must remove the .hub directory.

Its important we do this only when the --pack argument is not present.

@EstebanBorai
Copy link
Contributor Author

@sehz perhaps we could decouple --pack into its own command?

Just thinking while writing requirements that perhaps we would like to have these commands separated to keep consistency on side effects?

I think this would be more predictable:

# performs publishing to hub perhaps on dry run if on
cdk publish

# just produced the `.hub` directory with its contents
cdk pack

What do you think?

@sehz
Copy link
Contributor

sehz commented May 13, 2023

pack seems to be only relevant in publishing context and very special case so don't think warrant it's own command. It should be just flag in the publish command

@sehz sehz added this to the 0.10.10 milestone May 13, 2023
@sehz sehz added the DX/CDK Connector Developer Kit label May 13, 2023
@EstebanBorai
Copy link
Contributor Author

Resolved on #3259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX/CDK Connector Developer Kit
Projects
None yet
Development

No branches or pull requests

2 participants