[Merged by Bors] - fix: properly handle produce operation failure #3405
Conversation
galibey
force-pushed
the
feat/fix-producer-error-handling
branch
from
26dab10
to
92eef76
Compare
There was a problem hiding this comment.
The change and description LGTM.
Just for my information, I tracked the error code thru the Poll::Ready. Either::Right logic, but I'm not sure I have a full handle on all the places on the path the error code is handled now? Is BatchMetadata::base_offset the only place? Just doing some extra reading because the (offset,error) pair has to be a little bit more explictly handled vs a Result type.
To my understanding, yes. This method is called by |
|
bors r+ |
The failure of produce operation was mistakenly treated as a failure of the transportation layer, which is not. That led to non-helpful error reporting to the user: ```bash Producer error: failed to get record metadata ``` Fixed by not handling return error code too early.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
The failure of produce operation was mistakenly treated as a failure of the transportation layer, which is not. That led to non-helpful error reporting to the user:
Fixed by not handling return error code too early.