[Merged by Bors] - feat(fvm): install fluvio versions #3576

EstebanBorai · 2023-10-04T14:51:54Z

Introduces fvm install, similar to nvm install, downloads artifacts for the specific
Fluvio Version and stores them in ~/.fvm/versions for future use.

Along with downloading the artifacts, other routines are involved in this process:

Check binary Sha256 Sums
Provide executable permissions on Unix systems
Creating a manifest.json which helps determine the binaries versions

At this point no Fluvio Version is set as active/default, only the download of binaries is addressed as of this PR.

Demo

CleanShot.2023-10-04.at.16.16.14.mp4

crates/fluvio-hub-util/src/fvm/api.rs

ajhunyady · 2023-10-04T19:33:57Z

Does this command work with out parameters? I assume fvm install works (not in the video).

EstebanBorai · 2023-10-04T20:41:30Z

Does this command work with out parameters? I assume fvm install works (not in the video).

Yeah! By default fvm install will download stable

tests/cli/fvm_smoke_tests/fvm_basic.bats

As these are also being used for FVM on #3576.

crates/fluvio-version-manager/src/command/install.rs

tests/cli/fvm_smoke_tests/fvm_basic.bats

sehz · 2023-10-05T19:17:50Z

Also, the download could fail at any time. So in that case, the installation would need to be repeated

EstebanBorai · 2023-10-05T19:26:37Z

Also, the download could fail at any time. So in that case, the installation would need to be repeated

To be sure, like adding a retry?

sehz · 2023-10-05T19:39:15Z

Assume that the user should be able to retry the installation. that should be covered under CLI test

EstebanBorai · 2023-10-06T01:23:22Z

@sehz I think it would be nice to add some logic to delete existing version directory before copying if the directory already exists. What do you think?

EstebanBorai · 2023-10-06T01:24:51Z

@sehz I did different changes here: d07daa5, they are listed in the commit message. Will continue with remaining! Let we know your thoughts!

EstebanBorai · 2023-10-06T01:25:47Z

Im addressing tests at the end, when all behavior changes are applied!

sehz · 2023-10-06T02:35:59Z

As a general principle, the least changes to the user's file system are better. deleting directory is destructive operation which should be avoided much as possible

EstebanBorai · 2023-10-06T13:41:10Z

As a general principle, the least changes to the user's file system are better. deleting directory is destructive operation which should be avoided much as possible

Agree! In that example Im copying the binaries but as its seen FS complains. I will try with atomic copy and see if theres a different behavior.

EstebanBorai · 2023-10-06T14:58:56Z

@sehz here 81255f9 we are handling the already existent version.

sehz

LGTM. Nice CLI testing

EstebanBorai · 2023-10-12T01:16:35Z

LGTM. Nice CLI testing

Thanks for the support!

sehz · 2023-10-12T01:20:08Z

.github/workflows/ci.yml

@@ -1130,7 +1130,8 @@ jobs:
      - name: Run FVM smoke tests
        if: matrix.test == 'fvm'
        timeout-minutes: 20
-        run: make FVM_BIN=~/bin/fvm cli-fvm-smoke
+        run: |
+          make FVM_BIN=~/bin/fvm HUB_REGISTRY_URL="https://hub-dev.infinyon.cloud" cli-fvm-smoke


move HUB_REGISTRY_URL to env

Applying in next PR!

EstebanBorai · 2023-10-12T01:28:22Z

bors r+

Introduces `fvm install`, similar to `nvm install`, downloads artifacts for the specific Fluvio Version and stores them in `~/.fvm/versions` for future use. Along with downloading the artifacts, other routines are involved in this process: 1. Check binary Sha256 Sums 2. Provide executable permissions on Unix systems 3. Creating a `manifest.json` which helps determine the binaries versions At this point no Fluvio Version is set as active/default, only the download of binaries is addressed as of this PR. --- ## Demo https://github.com/infinyon/fluvio/assets/34756077/93b2115f-09ae-476f-b2ba-fbb1f9db2461

bors · 2023-10-12T01:50:23Z

Build failed:

Done

morenol · 2023-10-12T01:54:41Z

bors retry

Introduces `fvm install`, similar to `nvm install`, downloads artifacts for the specific Fluvio Version and stores them in `~/.fvm/versions` for future use. Along with downloading the artifacts, other routines are involved in this process: 1. Check binary Sha256 Sums 2. Provide executable permissions on Unix systems 3. Creating a `manifest.json` which helps determine the binaries versions At this point no Fluvio Version is set as active/default, only the download of binaries is addressed as of this PR. --- ## Demo https://github.com/infinyon/fluvio/assets/34756077/93b2115f-09ae-476f-b2ba-fbb1f9db2461

bors · 2023-10-12T02:21:41Z

Build failed:

Done

EstebanBorai · 2023-10-12T13:27:44Z

bors r+

Introduces `fvm install`, similar to `nvm install`, downloads artifacts for the specific Fluvio Version and stores them in `~/.fvm/versions` for future use. Along with downloading the artifacts, other routines are involved in this process: 1. Check binary Sha256 Sums 2. Provide executable permissions on Unix systems 3. Creating a `manifest.json` which helps determine the binaries versions At this point no Fluvio Version is set as active/default, only the download of binaries is addressed as of this PR. --- ## Demo https://github.com/infinyon/fluvio/assets/34756077/93b2115f-09ae-476f-b2ba-fbb1f9db2461

bors · 2023-10-12T13:52:38Z

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

Done

EstebanBorai commented Oct 4, 2023

View reviewed changes

crates/fluvio-hub-util/src/fvm/api.rs Outdated Show resolved Hide resolved

EstebanBorai force-pushed the 3573-fvm-package-set-downloads branch 6 times, most recently from 3fc2afc to a1e1b64 Compare October 4, 2023 18:45

sehz reviewed Oct 4, 2023

View reviewed changes

tests/cli/fvm_smoke_tests/fvm_basic.bats Outdated Show resolved Hide resolved

EstebanBorai mentioned this pull request Oct 5, 2023

[Merged by Bors] - chore: use surf and http-client as workspace deps #3581

Closed

bors bot pushed a commit that referenced this pull request Oct 5, 2023

chore: use surf and http-client as workspace deps (#3581)

56f58f8

As these are also being used for FVM on #3576.

EstebanBorai force-pushed the 3573-fvm-package-set-downloads branch from f9b359f to c3b317e Compare October 5, 2023 16:08

EstebanBorai marked this pull request as ready for review October 5, 2023 16:11

EstebanBorai force-pushed the 3573-fvm-package-set-downloads branch from c3b317e to b6e0d59 Compare October 5, 2023 17:49

sehz reviewed Oct 5, 2023

View reviewed changes

crates/fluvio-version-manager/src/command/install.rs Outdated Show resolved Hide resolved

sehz requested changes Oct 5, 2023

View reviewed changes

EstebanBorai force-pushed the 3573-fvm-package-set-downloads branch from 66f29cb to 9fe6309 Compare October 6, 2023 00:38

EstebanBorai requested a review from sehz October 6, 2023 15:01

EstebanBorai force-pushed the 3573-fvm-package-set-downloads branch 2 times, most recently from 2812263 to 24a0cd7 Compare October 7, 2023 20:27

EstebanBorai force-pushed the 3573-fvm-package-set-downloads branch 10 times, most recently from d0f37ab to 48c9bda Compare October 11, 2023 22:53

chore: review changes

902fef3

EstebanBorai force-pushed the 3573-fvm-package-set-downloads branch from 48c9bda to 902fef3 Compare October 11, 2023 23:37

feat: test with version list

dab3448

sehz approved these changes Oct 12, 2023

View reviewed changes

sehz reviewed Oct 12, 2023

View reviewed changes

fix: windows build support

fc6a53a

bors bot changed the title ~~feat(fvm): install fluvio versions~~ [Merged by Bors] - feat(fvm): install fluvio versions Oct 12, 2023

bors bot closed this Oct 12, 2023

EstebanBorai linked an issue Oct 12, 2023 that may be closed by this pull request

Fluvio Version Manager #3537

Closed

20 tasks

EstebanBorai deleted the 3573-fvm-package-set-downloads branch October 12, 2023 14:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Merged by Bors] - feat(fvm): install fluvio versions #3576

[Merged by Bors] - feat(fvm): install fluvio versions #3576

EstebanBorai commented Oct 4, 2023 •

edited

Loading

ajhunyady commented Oct 4, 2023

EstebanBorai commented Oct 4, 2023

sehz commented Oct 5, 2023

EstebanBorai commented Oct 5, 2023

sehz commented Oct 5, 2023

EstebanBorai commented Oct 6, 2023

EstebanBorai commented Oct 6, 2023

EstebanBorai commented Oct 6, 2023

sehz commented Oct 6, 2023

EstebanBorai commented Oct 6, 2023 •

edited

Loading

EstebanBorai commented Oct 6, 2023

sehz left a comment

EstebanBorai commented Oct 12, 2023

sehz Oct 12, 2023

EstebanBorai Oct 12, 2023

EstebanBorai commented Oct 12, 2023

bors bot commented Oct 12, 2023

morenol commented Oct 12, 2023

bors bot commented Oct 12, 2023

EstebanBorai commented Oct 12, 2023

bors bot commented Oct 12, 2023

[Merged by Bors] - feat(fvm): install fluvio versions #3576

[Merged by Bors] - feat(fvm): install fluvio versions #3576

Conversation

EstebanBorai commented Oct 4, 2023 • edited Loading

Demo

ajhunyady commented Oct 4, 2023

EstebanBorai commented Oct 4, 2023

sehz commented Oct 5, 2023

EstebanBorai commented Oct 5, 2023

sehz commented Oct 5, 2023

EstebanBorai commented Oct 6, 2023

EstebanBorai commented Oct 6, 2023

EstebanBorai commented Oct 6, 2023

sehz commented Oct 6, 2023

EstebanBorai commented Oct 6, 2023 • edited Loading

EstebanBorai commented Oct 6, 2023

sehz left a comment

Choose a reason for hiding this comment

EstebanBorai commented Oct 12, 2023

sehz Oct 12, 2023

Choose a reason for hiding this comment

EstebanBorai Oct 12, 2023

Choose a reason for hiding this comment

EstebanBorai commented Oct 12, 2023

bors bot commented Oct 12, 2023

morenol commented Oct 12, 2023

bors bot commented Oct 12, 2023

EstebanBorai commented Oct 12, 2023

bors bot commented Oct 12, 2023

EstebanBorai commented Oct 4, 2023 •

edited

Loading

EstebanBorai commented Oct 6, 2023 •

edited

Loading